Merge pull request #497 from microsoft/revert/pen

[SDK] Revert Pen and Tool Behaviors
microsoft · Mar 5, 2020 · ed44094 · ed44094
2 parents 49886ec + 7e84435
commit ed44094
Show file tree

Hide file tree

Showing 20 changed files with 108 additions and 532 deletions.
diff --git a/design/behavior.actions.md b/design/behavior.actions.md
diff --git a/design/high.resolution.transform.updates.md b/design/high.resolution.transform.updates.md
diff --git a/design/pen.behavior.md b/design/pen.behavior.md
diff --git a/design/set.behavior.actor.md b/design/set.behavior.actor.md
diff --git a/design/tool.behavior.md b/design/tool.behavior.md
diff --git a/packages/functional-tests/src/menu.ts b/packages/functional-tests/src/menu.ts
@@ -66,7 +66,7 @@ export class Menu {
 			this.breadcrumbs.reduce((submenu, choice) => submenu[choice].action as MenuItem[], MenuItems);
 
 		this.behaviors.forEach((behavior, i) => {
-			let handler: MRE.ActionHandler<void>;
+			let handler: MRE.ActionHandler;
 			let label: string;
 			let buttonMat: MRE.Material;
 

diff --git a/packages/sdk/src/actor/actor.ts b/packages/sdk/src/actor/actor.ts
@@ -585,7 +585,7 @@ export class Actor implements ActorLike, Patchable<ActorLike> {
 	 * @param grabState The grab state to fire the handler on.
 	 * @param handler The handler to call when the grab state has changed.
 	 */
-	public onGrab(grabState: 'begin' | 'end', handler: ActionHandler<void>) {
+	public onGrab(grabState: 'begin' | 'end', handler: ActionHandler) {
 		const actionState: ActionState = (grabState === 'begin') ? 'started' : 'stopped';
 		this.grab.on(actionState, handler);
 	}