This repository has been archived by the owner on Jun 10, 2022. It is now read-only.
Add reparenting functional test #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenvergenz
approved these changes
Feb 4, 2019
| for (let i = 0; i < 10 && this.running; ++i) { | ||
| await delay(100); | ||
| } | ||
| currParent = 1 - currParent; |
There was a problem hiding this comment.
This seems like a really strange way to iterate through a list. It works in this case because there are only two items, so I guess it's fine.
There was a problem hiding this comment.
Yes, just toggling the indices. Doesn't scale to more than two, but easily swapped out if we need to add more parents.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also sorting of the test list got lost in a merge somewhere so I restored it.