Add light-test, and related changes #173
Conversation
| return true; | ||
| } finally { | ||
| destroyActors(this.sceneRoot); | ||
| } | ||
| } |
There was a problem hiding this comment.
managing actors shouldn't be needed anymore, as functional test menu wrapper cleans up all actors on exit. It's fine to do it manually, but I think we agreed unnecessary, right? #Pending
There was a problem hiding this comment.
(just noting here because you added extra code around the destroy call)
In reply to: 254025155 [](ancestors = 254025155)
There was a problem hiding this comment.
| }); | ||
| }).value; | ||
| label.setBehavior(MRESDK.ButtonBehavior).onClick('released', () => this.running = false); | ||
|
|
There was a problem hiding this comment.
is this label clickable wihtout having a collidable flag set anywhere? are colliders created by setbehavior, or automatically, or am I not reading this right?
There was a problem hiding this comment.
This is here for the future when colliders on empty objects with text are possible. Of course by that time, we'll probably have a generalized way to exit a test and it won't be necessary.
In reply to: 254026146 [](ancestors = 254026146)
The light component is one of the oldest features of our API but hasn't been used much, so it was interesting to revisit it. I found a few places where it could be improved, and these changes also applied to the other actor components: text and rigid body. In summary: I removed the
enable-*payloads and instead relied on the actor patching mechanism to enable components. This was already 99% supported in the SDK, and 100% in the client, so theenable-*messages were unnecessary. This is a nice reduction in complexity! Checkout all the deleted code!Fixes issue #99
Clip of the light test in action
Other changes:
observemethod to be more self documenting.