This repository has been archived by the owner on Jun 10, 2022. It is now read-only.
Soren/fix mediainstance timing #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenhan
force-pushed
the
soren/fix-mediainstance-timing
branch
from
d8f15d2
to
4cb8df8
Compare
| }, | ||
| 0.0); | ||
| rolloffStartDistance: 2.5, | ||
| time: 30.0 |
There was a problem hiding this comment.
Was the time changed deliberately? 0 seconds vs 30 seconds?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes an unnecessary parameter (startTimeOffset - not needed when we have a time variable in setmediastateoptions), repairs the time calculation on join-in-progress (was broken if using seek, and if doing more than one join-in-progress).