This repository has been archived by the owner on Jun 10, 2022. It is now read-only.
Apply read-only asset properties after load #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eanders-ms
reviewed
Aug 20, 2019
| @@ -188,6 +188,8 @@ export class AssetContainer { | |||
| if (reply.failureMessage || reply.assets.length !== 1) { | |||
| throw new Error(`Creation/Loading of asset ${asset.name} failed: ${reply.failureMessage}`); | |||
There was a problem hiding this comment.
Unrelated feedback, but this shouldn't be throwing an exception. Log an error instead.
There was a problem hiding this comment.
This error bubbles up to rejecting the Asset.created promise. Isn't this what it's for?
In reply to: 315937817 [](ancestors = 315937817)
eanders-ms
approved these changes
Aug 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #418