This repository has been archived by the owner on Jun 10, 2022. It is now read-only.
Fix reparenting #20
Merged
Fix reparenting #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenvergenz
approved these changes
Feb 4, 2019
| @@ -155,7 +155,8 @@ internal void SynchronizeApp() | |||
|
|
|||
| internal void ApplyPatch(ActorPatch actorPatch) | |||
| { | |||
| var parent = ParentId != null ? App.FindActor(ParentId.Value) : Parent; | |||
| var parentId = actorPatch.ParentId ?? ParentId; | |||
| var parent = parentId != null ? App.FindActor(parentId.Value) : Parent; | |||
There was a problem hiding this comment.
Why are we patching parent in a separate function than the rest of the properties? Is this a holdover from the previous architecture?
There was a problem hiding this comment.
Yes, it looks like a holdover. Could easily be simplified now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steven noticed that reparenting wasn't working. This fixes that. FYI I coded it to preserve the child's local transform when reparenting.