Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve MoLeR generation visualisation for atom/motif choices #10

Merged
merged 7 commits into from
May 24, 2022
Merged

Improve MoLeR generation visualisation for atom/motif choices #10

merged 7 commits into from
May 24, 2022

Conversation

mmjb
Copy link
Contributor

@mmjb mmjb commented Apr 26, 2022

No description provided.

@mmjb mmjb requested a review from kmaziarz April 26, 2022 13:35
kmaziarz
kmaziarz reviewed Apr 26, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
kmaziarz
kmaziarz requested changes May 3, 2022
View reviewed changes
Copy link
Collaborator

@kmaziarz kmaziarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The visualizations look much more readable now; thanks! I've left a few comments, mostly around the visualise_from_samples mode (which seems to be already broken on main, but maybe we can fix it easily here).

molecule_generation/visualisation/moler_visualiser_html.py Show resolved Hide resolved
molecule_generation/visualisation/moler_visualiser_cli.py Outdated Show resolved Hide resolved
molecule_generation/utils/moler_visualisation_utils.py Outdated Show resolved Hide resolved
molecule_generation/visualisation/moler_visualiser_html.py Outdated Show resolved Hide resolved
molecule_generation/visualisation/moler_visualiser_cli.py Outdated Show resolved Hide resolved
@kmaziarz kmaziarz force-pushed the dev/mabrocks/visualiser_init_choice branch from 3eb75c2 to 520ac89 Compare May 16, 2022 16:48
@kmaziarz kmaziarz changed the title Improve MoLeR generation visualisation for init atom/motif choice Improve MoLeR generation visualisation for atom/motif choices May 24, 2022
@kmaziarz kmaziarz mentioned this pull request May 24, 2022
Open
3 tasks
kmaziarz
kmaziarz approved these changes May 24, 2022
View reviewed changes
Copy link
Collaborator

@kmaziarz kmaziarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I took this over and addressed my own suggestions, the PR seems good to go now. While doing this, I found many further quirks, which I dumped into #23.)

@kmaziarz kmaziarz merged commit 4c7dc57 into main May 24, 2022
@kmaziarz kmaziarz deleted the dev/mabrocks/visualiser_init_choice branch May 24, 2022 17:48
kmaziarz added a commit that referenced this pull request Jun 29, 2022
@kmaziarz
doc(CHANGELOG): Explicitly mention both changes in #10
97cf7c7
kmaziarz added a commit that referenced this pull request Jun 29, 2022
@kmaziarz
doc(CHANGELOG): Explicitly mention both changes in #10
4a03448
kmaziarz added a commit that referenced this pull request Jun 29, 2022
@kmaziarz
doc(CHANGELOG): Explicitly mention both changes in #10
909478e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmaziarz kmaziarz kmaziarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmjb @kmaziarz