-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve MoLeR generation visualisation for atom/motif choices #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The visualizations look much more readable now; thanks! I've left a few comments, mostly around the visualise_from_samples
mode (which seems to be already broken on main
, but maybe we can fix it easily here).
3eb75c2
to
520ac89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I took this over and addressed my own suggestions, the PR seems good to go now. While doing this, I found many further quirks, which I dumped into #23.)
No description provided.