Turn off parallel data loading in tests #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrwnmsr
approved these changes
Sep 1, 2023
kmaziarz
force-pushed
the
kmaziarz/fix-models-tests
branch
from
3dcebb2
to
f1c8c28
Compare
|
Closing as it does not seem to solve the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI pipeline hangs occasionally when running the more end-to-end model tests. This seems to be caused by the use of multiprocessing during data loading (which doesn't work too well in combination with
pytest). In this PR, I turn off parallel data loading in these tests, in hope that this will make the CI more stable.