Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Home page demo is broken #3853

Closed
2 tasks done
tamayika opened this issue Mar 21, 2023 · 2 comments · Fixed by #3855 · 4 remaining pull requests
Closed
2 tasks done

[Bug] Home page demo is broken #3853

tamayika opened this issue Mar 21, 2023 · 2 comments · Fixed by #3855 · 4 remaining pull requests

Comments

@tamayika
Copy link
Contributor

tamayika commented Mar 21, 2023

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Monaco Editor Playground Link

No response

Monaco Editor Playground Code

No response

Reproduction Steps

Open https://microsoft.github.io/monaco-editor/

Actual (Problematic) Behavior

Demo editor always shows loading...

Expected Behavior

Demo editor shows correct language sample code.

Additional Context

I noticed this when I was debugging Critical dependency: the request of a dependency is an expression webpack warning.
This warning comes from https://github.com/microsoft/monaco-editor/blob/main/website/src/website/pages/home/Home.tsx#L159.
But I don't know why webpack can not load file.
I also tried webpackMode: "eager" or webpackInclude: /\.txt?/ as reference mentioning here, but nothing solved.
If I specify static dependency as import(`../../data/home-samples/sample.typescript.txt`), it works correctly.

@hediet hediet mentioned this issue Mar 21, 2023
hediet added a commit that referenced this issue Mar 21, 2023
@hediet
Copy link
Member

hediet commented Mar 21, 2023

Thanks for reporting! It is unfortunate that this was not an error, just a warning.

@tamayika
Copy link
Contributor Author

Thanks for the quick fix!

I found a way to adopt TS 5.0.
Please see PR.

@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.