Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Document symbols are not working #3923

Closed
1 of 2 tasks
kisstkondoros opened this issue Apr 20, 2023 · 1 comment · Fixed by #3924
Closed
1 of 2 tasks

[Bug] Document symbols are not working #3923

kisstkondoros opened this issue Apr 20, 2023 · 1 comment · Fixed by #3924
Labels
bug Issue identified by VS Code Team member as probable bug typescript

Comments

@kisstkondoros
Copy link
Contributor

kisstkondoros commented Apr 20, 2023

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Monaco Editor Playground Link

https://microsoft.github.io/monaco-editor/playground.html?source=v0.37.1#XQAAAAL5BQAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscw93royzX2TCsdnO2pIhMCTyfRj--wy5DSlIBUX1GqvAaH8JMatJ3oD6eBcMyQf91t6mXAweMogaPgJwsffilU1dSzKzoGincsXXP8TgE9xQqMLiP4QMapT-8geCdu5si58VXalSecX8eHXM-lbhd94n-sGFbLjeLHSMzwn9Nfg6J8DReh0i1jgUW4xRwDev3anRRtDEQASFGPjr_YK9VwErECp890vKo07SqL4sSwLYYPRcCcP3SpaSG8EkB6KS2JM89MGjRI85SCXeWB8BJQCyGEgGrAbU6HnpJRn7JRuQmyJVHOzN-15IRP7XPwwrpwdVS7G25Gxuz9r44vFYKU2KL5zhwSM7qNqOeN6SJNVNzI0R8BeyNemNOoM-vNSdYk1kcSfG47mTwrqD27DEdRgvld1SPeugn75SnfzadpHKM3jMAOXJL_NitafdWHCrDc_QqfYHzdeSoByaLmUnKYU3e2TE_Nc35b5Gbdl55QnBYck7-W9RdVZWxh7PbUKaA6wxKic2BVE8BEir6xIFD5DMaX2H_6_q-rLVp-an7D_Ov02JnAQeQviGcKZmjZzAGqYH3JILD63VGg4R-c4MIvgYvXAO-wEz6vx11t6GmnmPjgdJtgn3_Y1yBUX_SQ6tY0uT58m6yEGuGhntf-5M3iBgqidsm_Om_kI59F3QNgUzwmDgvEti81yZC9uPF2Midda9N6JJrA2RM1_jAqqVR9ZmTpX5CNIMA5xODlhkQ8Og_-6r8sHCzXH2WQlQQpIn0QhvcVRu1aavGeACBVpCD2FBUAIbjj4Slu0DQ2Dm5vRGbn_yXymg0DTogGhZxPZsT_CQ4F4dJr2Qd-lZSbC6okIBxOHvB48ek7lhCr_uMNE7ycKX_q6K8QBM-Ym02CJtbrolKJVTtVb_wNz8ijgi-YOmbFboE1z6jd1BP7QGhq3BEqfhlkQyHJwQvgwcmsrw3hibpM4KQa4yT9j6WmFxJa315xhiHork6A5rfwxaF0_VVlLQ

Monaco Editor Playground Code

No response

Reproduction Steps

Create the editor with the following options:

{
    language: "typescript",
    stickyScroll: {
        enabled: true,
        maxLineCount: 3,
    },
}

An exception is immediately thrown due to invalid object access in

children: item.childItems?.map((child) => convert(child, result.name)),

Actual (Problematic) Behavior

No document symbols are available and (at least) the sticky scroll is not working

Expected Behavior

Document symbols are available and the sticky scroll is working

Additional Context

No response

kisstkondoros added a commit to kisstkondoros/monaco-editor that referenced this issue Apr 20, 2023
As the result object is about to be created, it can not be referred to when
mapping child items.

This fixes microsoft#3923
@hediet
Copy link
Member

hediet commented Apr 24, 2023

Thanks a lot for reporting this bug and providing the PR!

@hediet hediet added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities typescript and removed help wanted Issues identified as good community contribution opportunities labels Apr 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug typescript
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants