Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add koltin sample for website #1351

Merged
merged 1 commit into from
Sep 19, 2019
Merged

Add koltin sample for website #1351

merged 1 commit into from
Sep 19, 2019

Conversation

datou0412
Copy link
Contributor

No description provided.

@msftclas
Copy link

msftclas commented Mar 8, 2019

CLA assistant check
All CLA requirements met.

Copy link

@MairwunNx MairwunNx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would not be bad to fix some points that I requested.


fun accountsReport() {
println("EZ-Pass report:")
EZPassReport.forEach{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the kotlin code style, please put a space before the brace after foreach.

val EZPassAccounts: MutableMap<Int, Int> = mutableMapOf(1 to 100, 2 to 100, 3 to 100)
val EZPassReport: Map<Int, Int> = EZPassAccounts

// update points credit

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better use code documentation instead code comments in this case.

@alexdima alexdima added this to the August 2019 milestone Sep 19, 2019
@alexdima
Copy link
Member

Thank you! ❤️

@alexdima alexdima merged commit 1579caf into microsoft:master Sep 19, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants