Semantic tokens provider example #2103
Conversation
| }); | ||
|
|
||
| // currently there isn't builtin token handling | ||
| editor._themeService._knownThemes.forEach(function (theme) { |
There was a problem hiding this comment.
I'm not sure if the samples should be suggesting to people to use internals. In any case, this code should at least reference #1833 in a comment so that it gets more publicity and hopefully gets fixed.
There was a problem hiding this comment.
Maybe this is a bit ify, but if there is not other way... People are searching for this and there isn't complete example to try and play with.
Link could be useful, but probably comment with detailed explanation would be better.
There was a problem hiding this comment.
Link could be useful, but probably comment with detailed explanation would be better.
Well, a link is better than no link.
|
@alexdima since IE11 is no longer supported, can we use ES6 in playground examples? |
KapitanOczywisty
force-pushed
the
semanticTokens
branch
from
8886d7f
to
51fe304
Compare
|
Thank you! |
|
microsoft/vscode@6f59481 There is nothing more permanent than a temporary solution ;) |
|
@alexdima When will that change go live? The example on the website doesn't show me any colours. I'm using Firefox on Windows 10. |
|
I will note that having a working example on the website is meaningless without an updated library pushed to npm. 🤔 |
|
Yes, the plan was to publish a new editor version which would have made the sample to work correctly. But I found #2140 right before publishing so I decided to postpone releasing until that is fixed. |
This is simplified version of VSCode Semantic tokens sample adapted for monaco editor.