Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: A 'declare' modifier cannot be used in an already ambient context #2121

Merged
merged 2 commits into from
Sep 11, 2020

Conversation

xiaoxiangmoe
Copy link
Contributor

@xiaoxiangmoe xiaoxiangmoe commented Sep 11, 2020

Failed to compile.

/my-repo/node_modules/monaco-editor/esm/vs/editor/editor.api.d.ts
TypeScript error in /my-repo/node_modules/monaco-editor/esm/vs/editor/editor.api.d.ts(6235,5):
A 'declare' modifier cannot be used in an already ambient context.  TS1038

    6233 |         [index: string]: T;
    6234 |     }
  > 6235 |     declare type CompilerOptionsValue =
         |     ^
    6236 |         | string
    6237 |         | number
    6238 |         | boolean

@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Sep 11, 2020
alexdima added a commit to microsoft/monaco-typescript that referenced this pull request Sep 11, 2020
@alexdima alexdima added this to the August 2020 milestone Sep 11, 2020
@alexdima
Copy link
Member

Thank you!

@alexdima alexdima merged commit decded9 into microsoft:master Sep 11, 2020
pgherveou pushed a commit to pgherveou/monaco-typescript that referenced this pull request Sep 21, 2020
pgherveou pushed a commit to pgherveou/monaco-typescript that referenced this pull request Sep 21, 2020
* Format signature and parameter documentation as Markdown

* Add support for creating a custom webworker subclass

* Make a useful sample

* Tidy up

* Settle on customTSWorkerFactory

* Adds a vfs project

* Tightens the public API

* update deps

* update to typescript@4.0.2

* Add prettier

* Run prettier

* Use the global `monaco` only in the AMD case (see microsoft/monaco-editor#1974)

* Add deprecated diagnostic tag if a symbol is reported as deprecated

* Add deprecated tag to suggestion if entry is marked as deprecated

* Include tags in documentation string of suggestion items

* Align tag representation in suggestion items and hovers

* 4.0.0

* small style tweaks

* 4.0.1

* improve `.npmignore`

* Allows setting lib with shortnames

* Remove declare modifiers (microsoft/monaco-editor#2121)

* 4.0.2

* Update import TS

* Use typescript language for hover tooltip header

* update `package-lock.json`

* Adopt `async`

* Increase `printWidth`

* `var` -> `let`

* Fixes microsoft/monaco-editor#1937: Remove debugger statement

* Fixes microsoft/monaco-editor#1638: Protect against failing `getCodeFixesAtPosition` calls

* Fixes microsoft/monaco-editor#1998: make sure to always increase the version number

* Adopt latest `monaco-editor-core`, update to TS 4.0.3

* 4.1.0

* Add missing setWorkerOptions

* commit generated file

* update upstream and enable regex

Co-authored-by: Sebastian Pahnke <pahnke.sebastian@gmail.com>
Co-authored-by: Orta <git@orta.io>
Co-authored-by: Alex Dima <alexdima@microsoft.com>
Co-authored-by: Spencer <spencer@sf-n.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants