Change JSON symbol information to document symbol #3894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamayika
commented
Apr 6, 2023
| function toSymbolKind(kind: lsTypes.SymbolKind): languages.SymbolKind { | ||
| let mKind = languages.SymbolKind; | ||
|
|
||
| switch (kind) { | ||
| case lsTypes.SymbolKind.File: | ||
| return mKind.Array; | ||
| return mKind.File; |
There was a problem hiding this comment.
I found a small mistake in addition.
|
@hediet Please review this PR. |
aeschli
approved these changes
Dec 15, 2023
|
Thanks a lot, @tamayika ! |
dbaeumer
approved these changes
Dec 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playground
I found sticky scroll is not available for JSON.
This is because JSON's SymbolInformation is not hierarchical and we should use DocumentSymbol instead of SymbolInformation to support sticky scroll.