Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the cpp tokenizer, angled brackets (
<>
) were separated from other brackets to hold an additional post-condition:Not sure why, one guessed motivation is that a tokenizer needs to be extra careful with
<
since it might eventually resolve to the operator<<
. However,(1) this doesn't solve it,
<<
is still not tokenized to an operator (it fails all tokenizer regexes),(2) this extra-liberal exclusion causes bugs like #4253.
This suggested fix treats angled-brackets identically to other brackets. A true c++-conforming tokenizer might require
@rematch
and other heavy machinery, but this one is pretty certain to be at least some step forward.