Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

Add Scala support #98

Merged
merged 6 commits into from
Aug 27, 2020
Merged

Add Scala support #98

merged 6 commits into from
Aug 27, 2020

Conversation

ALANVF
Copy link
Contributor

@ALANVF ALANVF commented Jul 1, 2020

Added support for Scala syntax highlighting. Added some cool stuff like context-sensitive highlighting and some support for Dotty (Scala 3) syntax.

Here's an screenshot of some example code using the mode:
image

@alexdima alexdima added this to the August 2020 milestone Aug 27, 2020
@alexdima
Copy link
Member

Thank you!

@alexdima alexdima merged commit 2845e42 into microsoft:master Aug 27, 2020
@ALANVF
Copy link
Contributor Author

ALANVF commented Oct 25, 2020

Hey btw the usage of keyword.flow was completely intentional because there isn't any other way to use the color it provides.

@alexdima
Copy link
Member

Tokenization should be semantical, so we should not use keyword.flow i.e. generate a keyword token instead of an identifier token due to the default theme or because one color looks better.

It is possible to customize the theme and change the color of any token.

@ALANVF
Copy link
Contributor Author

ALANVF commented Dec 24, 2020

That makes sense I guess. I just hadn't thought about it because the monarch playground editor doesn't let you change the token colors

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants