Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversion is unnecessary for numeric parameters #1136

Merged
merged 9 commits into from
Jun 19, 2020
Merged

Conversion is unnecessary for numeric parameters #1136

merged 9 commits into from
Jun 19, 2020

Conversation

yitam
Copy link
Contributor

@yitam yitam commented May 25, 2020

No description provided.

@coveralls
Copy link

coveralls commented May 26, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 74.774% when pulling e120de4 on yitam:noConvert into 06d7a49 on microsoft:dev.

@codecov
Copy link

codecov bot commented Jun 3, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (dev@06d7a49). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev    #1136   +/-   ##
======================================
  Coverage       ?   77.55%           
======================================
  Files          ?       24           
  Lines          ?     7280           
  Branches       ?        0           
======================================
  Hits           ?     5646           
  Misses         ?     1634           
  Partials       ?        0

@yitam yitam requested a review from v-mabarw June 6, 2020 00:25
v-mabarw
v-mabarw approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@v-mabarw v-mabarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just some final minor cleanup.

source/shared/core_stmt.cpp
break;
case CP_UTF8:
sql_c_type = (is_a_numeric_type(sql_type)) ? SQL_C_CHAR : SQL_C_WCHAR;
//sql_c_type = SQL_C_WCHAR;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this line in clean up?

@yitam yitam merged commit f45f257 into microsoft:dev Jun 19, 2020
@yitam yitam deleted the noConvert branch June 19, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-mabarw v-mabarw v-mabarw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yitam @coveralls @v-mabarw