Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified implementations of last insert id and quote #1251

Merged
merged 3 commits into from
Apr 29, 2021
Merged

Simplified implementations of last insert id and quote #1251

merged 3 commits into from
Apr 29, 2021

Conversation

yitam
Copy link
Contributor

@yitam yitam commented Apr 29, 2021

The name column of sys.sequences is of type sysname, which is functionally equivalent to nvarchar(128).

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #1251 (e9ca8a6) into dev (fcd7b64) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head e9ca8a6 differs from pull request most recent head 591021d. Consider uploading reports for the commit 591021d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1251      +/-   ##
==========================================
- Coverage   82.86%   82.84%   -0.02%     
==========================================
  Files          24       24              
  Lines        7236     7222      -14     
==========================================
- Hits         5996     5983      -13     
+ Misses       1240     1239       -1     
Impacted Files Coverage Δ
.../x86/php-8.0.3-src/ext/sqlsrv/shared/core_init.cpp
.../vs16/x86/php-8.0.3-src/ext/pdo_sqlsrv/pdo_dbh.cpp
.../x86/php-8.0.3-src/ext/sqlsrv/shared/core_sqlsrv.h
.../phpdev/vs16/x86/php-8.0.3-src/ext/sqlsrv/init.cpp
.../x86/php-8.0.3-src/ext/sqlsrv/shared/core_stmt.cpp
.../php-8.0.3-src/ext/pdo_sqlsrv/shared/core_util.cpp
...vs16/x86/php-8.0.3-src/ext/pdo_sqlsrv/pdo_init.cpp
.../phpdev/vs16/x86/php-8.0.3-src/ext/sqlsrv/util.cpp
...16/x86/php-8.0.3-src/ext/pdo_sqlsrv/pdo_parser.cpp
.../php-8.0.3-src/ext/pdo_sqlsrv/shared/core_sqlsrv.h
... and 38 more

@yitam yitam merged commit 7fad440 into dev Apr 29, 2021
@yitam yitam deleted the pdo_api branch April 29, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant