Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified get_field_as_string and made it more robust #1265

Merged
merged 7 commits into from
Jun 8, 2021
Merged

Conversation

yitam
Copy link
Contributor

@yitam yitam commented Jun 5, 2021

Use the returned length from SQLGetData as an estimate and pad the buffer to avoid string truncation warning that might result with auto translation behind the scene.
See related issue #1261

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #1265 (e4a2505) into dev (a14cb70) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Current head e4a2505 differs from pull request most recent head edaed5b. Consider uploading reports for the commit edaed5b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1265      +/-   ##
==========================================
+ Coverage   83.43%   83.52%   +0.08%     
==========================================
  Files          22       22              
  Lines        7812     7780      -32     
==========================================
- Hits         6518     6498      -20     
+ Misses       1294     1282      -12     
Impacted Files Coverage Δ
.../php-8.0.7-src/ext/pdo_sqlsrv/shared/core_stmt.cpp 83.70% <0.00%> (+0.26%) ⬆️
.../x86/php-8.0.7-src/ext/sqlsrv/shared/core_stmt.cpp 85.31% <0.00%> (+0.28%) ⬆️

@yitam yitam merged commit af61d06 into dev Jun 8, 2021
@yitam yitam deleted the fetchStrings branch June 9, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant