Fix right truncation issue

[absci]

No description provided.

[codecov]

Codecov Report

Merging #1408 (6828586) into dev (109b8bc) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 6828586 differs from pull request most recent head 9dd14f4. Consider uploading reports for the commit 9dd14f4 to get more accurate results

@@            Coverage Diff             @@
##              dev    #1408      +/-   ##
==========================================
- Coverage   83.61%   83.59%   -0.03%     
==========================================
  Files          22       22              
  Lines        7853     7849       -4     
==========================================
- Hits         6566     6561       -5     
- Misses       1287     1288       +1     

Impacted Files	Coverage Δ
...s16/x86/php-8.0.19-src/ext/pdo_sqlsrv/pdo_stmt.cpp
...x86/php-8.0.19-src/ext/sqlsrv/shared/core_sqlsrv.h
...6/php-8.0.19-src/ext/sqlsrv/shared/core_stream.cpp
...phpdev/vs16/x86/php-8.0.19-src/ext/sqlsrv/init.cpp
...php-8.0.19-src/ext/pdo_sqlsrv/shared/core_stmt.cpp
...php-8.0.19-src/ext/pdo_sqlsrv/shared/core_util.cpp
...php-8.0.19-src/ext/pdo_sqlsrv/php_pdo_sqlsrv_int.h
...-8.0.19-src/ext/pdo_sqlsrv/shared/core_results.cpp
...s16/x86/php-8.0.19-src/ext/pdo_sqlsrv/pdo_init.cpp
...phpdev/vs16/x86/php-8.0.19-src/ext/sqlsrv/util.cpp
... and 34 more

[talkinnl]

Feel free to adopt the tests of #1404 inside this PR. Might raise codecov and also proves that the fix works. :)

[absci]

Feel free to adopt the tests of #1404 inside this PR. Might raise codecov and also proves that the fix works. :)

I have pulled your unit test to this PR. Seems the fix is working but somehow the test throws a Warning: Array to string conversion in /home/vsts/work/1/s/test/functional/pdo_sqlsrv/pdo_1391_string_truncation_after_short_string.php on line 56

[talkinnl]

@absci : My bad, fetchAll() should've been fetch()

[talkinnl]

I've updated my branch and PR. But it just comes down to replacing 'fetchAll()' by 'fetch()'.

[absci]

I've updated my branch and PR. But it just comes down to replacing 'fetchAll()' by 'fetch()'.

Thanks, all tests passed now.

[v-mabarw]

Please separate the additional trigger into another PR.

[talkinnl]

@absci and reviewers: Thanks for the quick review and merge! 🥇

May I ask if you've got a date set for the next fix version? Sorry if I come across a bit pushy, but I'm just excited to be a able to update a huge Doctrine project to PHP 8.1. :)