Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ExtensionVer regex #449

Merged
merged 4 commits into from
Jun 21, 2017
Merged

fix ExtensionVer regex #449

merged 4 commits into from
Jun 21, 2017

Conversation

yitam
Copy link
Contributor

@yitam yitam commented Jun 21, 2017

changed the version from rc to RC with possible numbers

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.337% when pulling 267271e on yitam:extensionVer into 219de93 on Microsoft:dev.

@Hadis-Knj Hadis-Knj mentioned this pull request Jun 21, 2017
Closed
Hadis-Knj
Hadis-Knj reviewed Jun 21, 2017
View reviewed changes
Copy link

@Hadis-Knj Hadis-Knj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the regex would match 1.2.3randomstuff, see #448. can be fixed by enclosing the pattern with beginning ^ and $ markers

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.337% when pulling 3e1e75c on yitam:extensionVer into 219de93 on Microsoft:dev.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.337% when pulling 67dca1c on yitam:extensionVer into 219de93 on Microsoft:dev.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.337% when pulling f1872d5 on yitam:extensionVer into 219de93 on Microsoft:dev.

@Hadis-Knj Hadis-Knj merged commit f5be531 into microsoft:dev Jun 21, 2017
@yitam yitam deleted the extensionVer branch June 21, 2017 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hadis-Knj Hadis-Knj Hadis-Knj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yitam @coveralls @Hadis-Knj @msftclas