Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log for RC #639

Merged
merged 1 commit into from
Dec 20, 2017
Merged

Change log for RC #639

merged 1 commit into from
Dec 20, 2017

Conversation

yitam
Copy link
Contributor

@yitam yitam commented Dec 19, 2017

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.504% when pulling d597e47 on yitam:changeLog into 35146b7 on Microsoft:dev.

@codecov-io
Copy link

codecov-io commented Dec 20, 2017

Codecov Report

Merging #639 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #639   +/-   ##
=======================================
  Coverage   77.13%   77.13%           
=======================================
  Files          25       25           
  Lines        7317     7317           
=======================================
  Hits         5644     5644           
  Misses       1673     1673

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35146b7...d597e47. Read the comment docs.

@yitam yitam requested a review from yukiwongky December 20, 2017 18:26
- Fixed warnings as per Prefast code analysis

### Limitations
- In Linux and macOS, setlocale() only takes effect if it is invoked before the first connection. The subsequent locale setting will not work
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if you need it here if it's already in aelimitation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not AE related though ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yea nvm, please go ahead and merge

@yitam yitam merged commit e92f1a5 into microsoft:dev Dec 20, 2017
@yitam yitam deleted the changeLog branch December 20, 2017 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants