Remove the limitation of getting binary as strings as INOUT param #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #759 +/- ##
==========================================
+ Coverage 78.85% 78.86% +<.01%
==========================================
Files 25 25
Lines 7157 7160 +3
==========================================
+ Hits 5644 5647 +3
Misses 1513 1513
Continue to review full report at Codecov.
|
| @@ -1180,9 +1180,10 @@ int pdo_sqlsrv_stmt_param_hook( _Inout_ pdo_stmt_t *stmt, | |||
| } | |||
| // if the parameter is output or input/output, translate the type between the PDO::PARAM_* constant | |||
| // and the SQLSRV_PHPTYPE_* constant | |||
| int pdo_type = param->param_type; | |||
| // vso 2829: derive the pdo_type for input/output parameter as well | |||
| int pdo_type = (direction == SQL_PARAM_OUTPUT) ? param->param_type : param->param_type & ~PDO_PARAM_INPUT_OUTPUT; | |||
There was a problem hiding this comment.
What does the syntax & ~ do here?
There was a problem hiding this comment.
It's deriving the pdo param type (see original line 1185) using bitwise operators because for inout params the param type is "bitwise ORed". For example, PDO::PARAM_STR | PDO::PARAM_INPUT_OUTPUT
david-puglielli
approved these changes
May 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is