Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QUIC_TLS_SECRETS Not Fully Populated on Server #2344

Closed
5 of 6 tasks
nibanks opened this issue Jan 28, 2022 · 0 comments · Fixed by #3539
Closed
5 of 6 tasks

QUIC_TLS_SECRETS Not Fully Populated on Server #2344

nibanks opened this issue Jan 28, 2022 · 0 comments · Fixed by #3539
Labels
Area: API Area: Core Related to the shared, core protocol logic Bug: Core A code bug in the Core MsQuic code
Milestone
Release 2.2

Comments

@nibanks
Copy link
Member

nibanks commented Jan 28, 2022

Describe the bug

The ClientRandom isn't populated in the QUIC_TLS_SECRETS for the server side, because the code reads that from the TLS ClientHello before the connection is even indicated to the listener; meaning the app didn't have a chance to set the pointer to the struct to be written to.

Affected OS

  • Windows Server 2022
  • Windows 11
  • Windows Insider Preview (specify affected build below)
  • Ubuntu
  • Debian
  • Other (specify below)

Additional OS information

No response

MsQuic version

main

Steps taken to reproduce bug

Try to query the QUIC_TLS_SECRETS.

Expected behavior

They are fully populated.

Actual outcome

Everything but ClientRandom is populated.

Additional details

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: API Area: Core Related to the shared, core protocol logic Bug: Core A code bug in the Core MsQuic code
Projects
None yet
Milestone
Release 2.2
Development

Successfully merging a pull request may close this issue.

Fix QUIC_TLS_SECRETS on Server and Client. microsoft/msquic
1 participant
@nibanks