Experiment /fsanitize=address for tests #3708
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
reviewed
Jun 16, 2023
| @@ -22,7 +22,7 @@ target_link_libraries(msquictest inc gtest logging base_link) | |||
|
|
|||
| # At least /W3 must be used on all windows builds to pass compliance | |||
| if(MSVC) | |||
| target_compile_options(msquictest PRIVATE /W3 /bigobj) | |||
| target_compile_options(msquictest PRIVATE /W3 /bigobj /fsanitize=address) | |||
There was a problem hiding this comment.
I didn't realize tests weren't using the same flags. FYI, there are 3 tests that might need this flag in total.
There was a problem hiding this comment.
Build still failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just an experiment.