Consume XDP v0.17.0 #3779
Merged
Consume XDP v0.17.0 #3779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csujedihy
reviewed
Jul 27, 2023
csujedihy
previously approved these changes
Jul 27, 2023
nibanks
reviewed
Jul 27, 2023
scripts/prepare-machine.ps1
Outdated
| @@ -251,7 +246,7 @@ function Install-Xdp-Driver { | |||
| } | |||
|
|
|||
| Write-Host "Installing XDP driver" | |||
| netcfg.exe -l "$XdpPath\bin\xdp.inf" -c s -i ms_xdp | |||
| msiexec.exe /i $XdpPath\bin\xdp-for-windows.msi /quiet | |||
There was a problem hiding this comment.
So this automatically uninstalls anything previously installed? Is that why you removed the delete above?
There was a problem hiding this comment.
It uninstalls anything that has been installed using this package. It would be an error for something else to leave XDP installed.
nibanks
reviewed
Jul 27, 2023
nibanks
reviewed
Jul 27, 2023
nibanks
reviewed
Jul 27, 2023
nibanks
reviewed
Jul 27, 2023
nibanks
reviewed
Jul 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #3779 +/- ##
==========================================
- Coverage 77.59% 77.07% -0.53%
==========================================
Files 56 56
Lines 15558 15558
==========================================
- Hits 12073 11991 -82
- Misses 3485 3567 +82 |
nibanks
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to XDP v0.17.0 This contains a number of editorial API changes and an MSI installer. The QEO function is also now an optional function in XDP.
Testing
Builds locally. CI/CD.
Documentation
I don't think so.