-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Debian 12 package & fix Fedora 37 package #3789
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3789 +/- ##
==========================================
- Coverage 77.79% 76.99% -0.80%
==========================================
Files 56 56
Lines 15558 15558
==========================================
- Hits 12103 11979 -124
- Misses 3455 3579 +124 |
The change literally only touches a publishing script 🤷♀️ I have no idea how this can affect code coverage, especially mysterious are those "indirect changes" 😅 |
It's not you. Code coverage has a random element to it, so it varies some run to run. Just ignore this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I want @csujedihy to look on Monday.
should this be ported to release branch(es)? |
@csujedihy do we need to backport these package changes to run them for a release branch? Also, can we rerun the publish for a release that was already previously published or do we need to make a new release? |
We do at least for now. The branch being tagged is the release branch. The publishing automation is triggered by tags.
We could just rerun the pipeline but I'd rather not try to publish the same version more than once. Last time I did this, I somewhat broke PMC. I was politely warned by PMC folks not to do it again. Though, they fixed all the bugs that I found. |
@nibanks @csujedihy I see that the packages are still unavailable, is there anything else that should be done? Or are we just waiting for the next release? If so, do you have any ETA on when that will happen? |
The packages for the new distros should be published with the next release. Republishing an existing version is possible but I want to avoid doing that. I think mid-October we will have to release a new version? @nibanks |
This is very confusing: despite 2.2.3 version being out, there's still no package for Debian 12, and Fedora 37 2.2.3 package is still for OpenSSL 3.0, not 1.1 (so it still doesn't work). @nibanks @csujedihy can you please help? |
Talked with @CarnaViire on IM. Looks like we missed a backport PR. Sorry! We will backport it real quick and try to create a quick v2.2.4 just for this. |
Description
Adds Debian 12 (bookworm) to the list of distros to publish to. Debian 12 was released on June 10. The distro already exists on packages.microsoft.com. LMK if I've missed something @nibanks @csujedihy
The second change is an attempt to fix Fedora 37 usecase, which has strange problems with OpenSSL 3 package (#3640 (comment)). However, the distro has a compat OpenSSL 1.1 package, so I propose to fallback to that, given that the distro will be supported only until 2023-11-14.
Testing
I've verified that Ubuntu 22.04 package (OpenSSL 3) works on Debian 12, and that CentOS 8 package (OpenSSL 1.1) works on Fedora 37 (verification script). I don't have access to verify actual publish scripts.
Documentation
N/A
cc @wfurt @ManickaP