Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debian 12 package & fix Fedora 37 package #3789

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

CarnaViire
Copy link
Member

Description

Adds Debian 12 (bookworm) to the list of distros to publish to. Debian 12 was released on June 10. The distro already exists on packages.microsoft.com. LMK if I've missed something @nibanks @csujedihy

The second change is an attempt to fix Fedora 37 usecase, which has strange problems with OpenSSL 3 package (#3640 (comment)). However, the distro has a compat OpenSSL 1.1 package, so I propose to fallback to that, given that the distro will be supported only until 2023-11-14.

Testing

I've verified that Ubuntu 22.04 package (OpenSSL 3) works on Debian 12, and that CentOS 8 package (OpenSSL 1.1) works on Fedora 37 (verification script). I don't have access to verify actual publish scripts.

Documentation

N/A

cc @wfurt @ManickaP

@CarnaViire CarnaViire requested a review from a team as a code owner August 4, 2023 11:51
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #3789 (c9ed2ed) into main (e03d496) will decrease coverage by 0.80%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3789      +/-   ##
==========================================
- Coverage   77.79%   76.99%   -0.80%     
==========================================
  Files          56       56              
  Lines       15558    15558              
==========================================
- Hits        12103    11979     -124     
- Misses       3455     3579     +124     

see 14 files with indirect coverage changes

@CarnaViire
Copy link
Member Author

The change literally only touches a publishing script 🤷‍♀️ I have no idea how this can affect code coverage, especially mysterious are those "indirect changes" 😅

@nibanks
Copy link
Member

nibanks commented Aug 4, 2023

The change literally only touches a publishing script 🤷‍♀️ I have no idea how this can affect code coverage, especially mysterious are those "indirect changes" 😅

It's not you. Code coverage has a random element to it, so it varies some run to run. Just ignore this.

Copy link
Member

@nibanks nibanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I want @csujedihy to look on Monday.

@nibanks nibanks merged commit 0f14632 into microsoft:main Aug 4, 2023
407 of 408 checks passed
@wfurt
Copy link
Member

wfurt commented Aug 4, 2023

should this be ported to release branch(es)?

@nibanks
Copy link
Member

nibanks commented Aug 8, 2023

should this be ported to release branch(es)?

@csujedihy do we need to backport these package changes to run them for a release branch? Also, can we rerun the publish for a release that was already previously published or do we need to make a new release?

@csujedihy
Copy link
Contributor

do we need to backport these package changes to run them for a release branch?

We do at least for now. The branch being tagged is the release branch. The publishing automation is triggered by tags.

Also, can we rerun the publish for a release that was already previously published or do we need to make a new release?

We could just rerun the pipeline but I'd rather not try to publish the same version more than once. Last time I did this, I somewhat broke PMC. I was politely warned by PMC folks not to do it again. Though, they fixed all the bugs that I found.

@CarnaViire
Copy link
Member Author

@nibanks @csujedihy I see that the packages are still unavailable, is there anything else that should be done? Or are we just waiting for the next release? If so, do you have any ETA on when that will happen?

@csujedihy
Copy link
Contributor

The packages for the new distros should be published with the next release. Republishing an existing version is possible but I want to avoid doing that. I think mid-October we will have to release a new version? @nibanks

@CarnaViire
Copy link
Member Author

This is very confusing: despite 2.2.3 version being out, there's still no package for Debian 12, and Fedora 37 2.2.3 package is still for OpenSSL 3.0, not 1.1 (so it still doesn't work). @nibanks @csujedihy can you please help?

@nibanks
Copy link
Member

nibanks commented Oct 16, 2023

Talked with @CarnaViire on IM. Looks like we missed a backport PR. Sorry! We will backport it real quick and try to create a quick v2.2.4 just for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants