Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/2.3] Don't send client CONNECTION_CLOSE on 1-RTT before handshake completion. (#4145) #4164

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Feb 29, 2024

Ports #4145 to release/2.3

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.74%. Comparing base (cb79889) to head (41bd50a).

Additional details and impacted files
@@               Coverage Diff               @@
##           release/2.3    #4164      +/-   ##
===============================================
- Coverage        87.35%   86.74%   -0.61%     
===============================================
  Files               56       56              
  Lines            16984    16987       +3     
===============================================
- Hits             14837    14736     -101     
- Misses            2147     2251     +104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rzikm
Copy link
Member Author

rzikm commented Feb 29, 2024

We should probably hold on this before merging, the fix I did may not be enough in some cases (see dotnet/runtime#99074)

@rzikm rzikm marked this pull request as draft February 29, 2024 10:44
@rzikm rzikm marked this pull request as ready for review February 29, 2024 14:13
@rzikm
Copy link
Member Author

rzikm commented Feb 29, 2024

False alarm, we hit a slightly different bug: #4166 which can be fixed separately.

@nibanks nibanks merged commit 5cbc704 into microsoft:release/2.3 Feb 29, 2024
339 of 340 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants