Prunable Pool Allocator #4517
Merged
Prunable Pool Allocator #4517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfriesen
reviewed
Aug 29, 2024
mtfriesen
reviewed
Aug 29, 2024
nibanks
commented
Aug 31, 2024
| @@ -696,12 +696,6 @@ TEST_F(DataPathTest, InitializeInvalid) | |||
| ASSERT_EQ(QUIC_STATUS_INVALID_PARAMETER, Datapath.GetInitStatus()); | |||
| ASSERT_EQ(nullptr, Datapath.Datapath); | |||
| } | |||
| if (!UseDuoNic) { | |||
There was a problem hiding this comment.
This test case is invalid if you have XDP installed locally (which I do).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4517 +/- ##
==========================================
- Coverage 86.24% 85.06% -1.18%
==========================================
Files 56 56
Lines 15520 15520
==========================================
- Hits 13385 13202 -183
- Misses 2135 2318 +183 ☔ View full report in Codecov by Sentry. |
mtfriesen
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the datapath RX buffers (on Windows) to periodically prune items to keep from growing and holding on to too much memory.
Testing
CI/CD
Documentation
N/A