Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Linux Send Complete Status #4538

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Fix Linux Send Complete Status #4538

merged 1 commit into from
Sep 9, 2024

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Sep 8, 2024

Description

Linux TCP was recently broken when secnetperf was updated to handle send completion errors. This exposed a bug in the platform layer that was always passing up errno incorrectly.

This PR updates the platform abstraction to return the proper status.

Testing

Verified locally on Linux GitHub Codespaces. CI/CD

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner September 8, 2024 12:32
@nibanks nibanks added OS: Ubuntu Bug: Platform A code bug in platform/TLS specific code. labels Sep 8, 2024
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.03%. Comparing base (e5aa857) to head (beb4e26).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4538      +/-   ##
==========================================
- Coverage   86.12%   86.03%   -0.10%     
==========================================
  Files          56       56              
  Lines       15520    15520              
==========================================
- Hits        13367    13353      -14     
- Misses       2153     2167      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks enabled auto-merge (squash) September 9, 2024 12:51
@nibanks nibanks merged commit 8ee995e into main Sep 9, 2024
470 of 471 checks passed
@nibanks nibanks deleted the fix-linux-tcp-send-complete branch September 9, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Platform A code bug in platform/TLS specific code. OS: Ubuntu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants