Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance | Disabled pattern matching when using CallableStatements and SQLServerParameterMetaData #1149

Merged
merged 7 commits into from
Oct 4, 2019
Merged

Performance | Disabled pattern matching when using CallableStatements and SQLServerParameterMetaData #1149

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b75ee55
Try turning off pattern mathching
ulvii Jul 25, 2019
86e050b
Merge remote-tracking branch 'upstream/dev' into issue1112
ulvii Sep 18, 2019
43ae27b
Fix | concatenate parameters
ulvii Sep 18, 2019
f73b2d9
Merge remote-tracking branch 'upstream/dev' into issue1112
ulvii Sep 24, 2019
a1ad042
Merge remote-tracking branch 'upstream/dev' into issue1112
ulvii Oct 2, 2019
7a402af
Fix | Apply the change to SQLServerParameterMetaData as well
ulvii Oct 2, 2019
66047d2
Merge remote-tracking branch 'upstream/dev' into issue1112
ulvii Oct 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/microsoft/sqlserver/jdbc/SQLServerCallableStatement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1279,7 +1279,7 @@ private int findColumn(String columnName) throws SQLServerException {
// we should always have a procedure name part
metaQuery.append("@procedure_name=");
metaQuery.append(threePartName.getProcedurePart());
metaQuery.append(" , @ODBCVer=3");
metaQuery.append(" , @ODBCVer=3, @fUsePattern=0");
ulvii marked this conversation as resolved.
Show resolved Hide resolved
} else {
// This should rarely happen, this will only happen if we can't find the stored procedure name
// invalidly formatted call syntax.
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/microsoft/sqlserver/jdbc/SQLServerParameterMetaData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,8 +289,8 @@ private void checkClosed() throws SQLServerException {
try (SQLServerStatement s = (SQLServerStatement) con.createStatement(ResultSet.TYPE_SCROLL_INSENSITIVE,
ResultSet.CONCUR_READ_ONLY);
SQLServerResultSet rsProcedureMeta = s.executeQueryInternal(
con.isKatmaiOrLater() ? "exec sp_sproc_columns_100 " + sProc + ", @ODBCVer=3"
: "exec sp_sproc_columns " + sProc + ", @ODBCVer=3")) {
con.isKatmaiOrLater() ? "exec sp_sproc_columns_100 " + sProc + ", @ODBCVer=3, @fUsePattern=0"
: "exec sp_sproc_columns " + sProc + ", @ODBCVer=3, @fUsePattern=0")) {

// if rsProcedureMeta has next row, it means the stored procedure is found
if (rsProcedureMeta.next()) {
Expand Down