-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remade attestation NONE to work in all cases #1942
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ONE should be allowed without a protocol.
lilgreenbird
previously approved these changes
Oct 27, 2022
Jeffery-Wasty
changed the title
Fix attestation for NONE as it's now broken
Changes for attestation NONE to work in all cases
Oct 27, 2022
Jeffery-Wasty
changed the title
Changes for attestation NONE to work in all cases
Remade attestation NONE to work in all cases
Oct 27, 2022
tkyc
previously approved these changes
Oct 27, 2022
David-Engel
previously approved these changes
Oct 27, 2022
…ONE should be allowed without a protocol.
…ql-jdbc into attestationNoneFix
Jeffery-Wasty
dismissed stale reviews from David-Engel, tkyc, and lilgreenbird
via
October 28, 2022 18:08
ab8e54d
tkyc
approved these changes
Oct 31, 2022
David-Engel
approved these changes
Oct 31, 2022
lilgreenbird
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our original implementation of attestation NONE did work, but as was later shown, not for all cases, and thus a fix was needed. This new NONE enclave provider is a copy of our HGS/VSM enclave provider with attestation validation stripped, and response validation stripped to only what is needed.
SQLServerNoneEnclaveProvider:
EnclavePackageTest