-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for bigDecimal values between 0 and 1 having too high of a precision #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeffery-Wasty
changed the title
Fix for numbers between 0 and 1.
Fix for bigDecimal values between 0 and 1 having too high of a precision
May 2, 2023
lilgreenbird
reviewed
May 2, 2023
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/StatementTest.java
Show resolved
Hide resolved
lilgreenbird
reviewed
May 2, 2023
…value beforehand.
Jeffery-Wasty
force-pushed
the
bigDecimalLessThan1Fix
branch
from
May 4, 2023 16:32
f8aa81e
to
f381a1a
Compare
lilgreenbird
approved these changes
May 4, 2023
tkyc
pushed a commit
that referenced
this pull request
Jul 26, 2023
…es between 0 and 1 having too high of a precision) (#2176) * Revert big decimal changes * Delete TestClass.java * Delete RetryLogicProvider.java * Update Parameter.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes how precision and scaling are computed for bigDecimal values to account for a big where precision is 1 too high for numbers between 0 and 1.