-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish support for RFC4180 for CSV bulk insert operations #2338
Finish support for RFC4180 for CSV bulk insert operations #2338
Conversation
…umnDelimitersCSV is set to true
@microsoft-github-policy-service agree |
thank you for your contribution, the team will take a look at this when time permits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appears to handle newline in Mac, Linux, and Windows formats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use file formatter to format this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use file formatter to format this PR all files need to be formatted before merge
32656a6
I think I have what you are looking for now. |
RFC4180 specifies support for fields that contain newlines as long as they are quoted. See section 6 in the specification here: https://www.ietf.org/rfc/rfc4180.txt
This PR enhances the read operation when the option escapeColumnDelimitersCSV is set to true to allow newline characters to survive the CSV parse process and find their way into the record. An existing unit test was enhanced to test the behavior.