Added credential caching for Managed Identity Credential and Default Azure Credential #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2415 +/- ##
============================================
- Coverage 50.21% 50.13% -0.09%
+ Complexity 3843 3841 -2
============================================
Files 145 145
Lines 33355 33396 +41
Branches 5654 5662 +8
============================================
- Hits 16750 16742 -8
- Misses 14209 14260 +51
+ Partials 2396 2394 -2 ☔ View full report in Codecov by Sentry. |
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerSecurityUtility.java
Outdated
Show resolved
Hide resolved
lilgreenbird
previously approved these changes
May 14, 2024
David-Engel
reviewed
May 15, 2024
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerSecurityUtility.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerSecurityUtility.java
Outdated
Show resolved
Hide resolved
tkyc
force-pushed
the
credential-caching
branch
5 times, most recently
from
0dd0973 to
ed05d8f
Compare
David-Engel
reviewed
May 15, 2024
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerSecurityUtility.java
Outdated
Show resolved
Hide resolved
David-Engel
reviewed
May 16, 2024
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerSecurityUtility.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerSecurityUtility.java
Outdated
Show resolved
Hide resolved
David-Engel
reviewed
May 16, 2024
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerSecurityUtility.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerSecurityUtility.java
Outdated
Show resolved
Hide resolved
…ility.java Co-authored-by: David Engel <v-davidengel@microsoft.com>
…ility.java Co-authored-by: David Engel <v-davidengel@microsoft.com>
David-Engel
previously approved these changes
May 16, 2024
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerSecurityUtility.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerSecurityUtility.java
Outdated
Show resolved
Hide resolved
|
Also run formatter, minor formatting issues are present. |
Jeffery-Wasty
approved these changes
May 21, 2024
lilgreenbird
approved these changes
May 21, 2024
lilgreenbird
changed the title
tkyc
added a commit
that referenced
this pull request
May 22, 2024
tkyc
added a commit
that referenced
this pull request
May 22, 2024
tkyc
changed the title
tkyc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added credential caching for ManagedIdentityCredential and DefaultAzureCredential.