Updates for running tests with managed identity #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2416 +/- ##
============================================
- Coverage 50.24% 50.11% -0.13%
+ Complexity 3843 3832 -11
============================================
Files 145 145
Lines 33355 33355
Branches 5654 5654
============================================
- Hits 16758 16717 -41
- Misses 14205 14239 +34
- Partials 2392 2399 +7 ☔ View full report in Codecov by Sentry. |
|
Also can you remove the comment in SharedTimerTest::32,33. |
tkyc
previously approved these changes
May 21, 2024
tkyc
previously approved these changes
May 21, 2024
Jeffery-Wasty
previously approved these changes
May 21, 2024
tkyc
approved these changes
May 21, 2024
Jeffery-Wasty
approved these changes
May 21, 2024
tkyc
pushed a commit
that referenced
this pull request
May 22, 2024
tkyc
added a commit
that referenced
this pull request
May 23, 2024
* Updates for running tests with managed identity (#2416) * Updated tests for removal of secrets * Reverted TimeoutTests * AE config port * TimeoutTests update --------- Co-authored-by: lilgreenbird <v-susanh@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.