Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed regression with specifying arg names in call syntax #2480

Merged
merged 8 commits into from
Jul 23, 2024
Merged

Fixed regression with specifying arg names in call syntax #2480

merged 8 commits into from
Jul 23, 2024
+34 −2

Conversation

tkyc
Copy link
Member

@tkyc tkyc commented Jul 22, 2024

Fixes #2477

@codecov Codecov
Copy link

codecov bot commented Jul 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.81%. Comparing base (aef7c5d) to head (c252a8b).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2480      +/-   ##
============================================
+ Coverage     50.76%   50.81%   +0.05%     
- Complexity     3886     3902      +16     
============================================
  Files           145      145              
  Lines         33481    33481              
  Branches       5690     5690              
============================================
+ Hits          16998    17015      +17     
- Misses        14043    14046       +3     
+ Partials       2440     2420      -20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Jeffery-Wasty
Jeffery-Wasty previously approved these changes Jul 22, 2024
View reviewed changes
barryw-mssql
barryw-mssql previously approved these changes Jul 22, 2024
View reviewed changes
lilgreenbird
lilgreenbird previously approved these changes Jul 23, 2024
View reviewed changes
@tkyc tkyc dismissed stale reviews from lilgreenbird, barryw-mssql, and Jeffery-Wasty via c252a8b July 23, 2024 17:22
@tkyc tkyc merged commit 0e97689 into main Jul 23, 2024
19 checks passed
@tkyc tkyc deleted the call-escape-syntax-fix branch July 23, 2024 19:00
@Eng-Fouad Eng-Fouad mentioned this pull request Aug 1, 2024
Merged
@Jeffery-Wasty Jeffery-Wasty added this to the 12.8.0 milestone Aug 1, 2024
Jeffery-Wasty added a commit that referenced this pull request Aug 6, 2024
@Jeffery-Wasty
Revert "Fixed regression with specifying arg names in call syntax (#2480
6762707 
)"

This reverts commit 0e97689.
@tkyc tkyc mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barryw-mssql barryw-mssql barryw-mssql approved these changes

@Jeffery-Wasty Jeffery-Wasty Jeffery-Wasty approved these changes

@lilgreenbird lilgreenbird lilgreenbird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
MSSQL JDBC
Status: Closed/Merged PRs
Milestone
12.8.0
Development

Successfully merging this pull request may close these issues.

12.6.3 procedure return value regression
4 participants
@tkyc @lilgreenbird @Jeffery-Wasty @barryw-mssql