Prepared statement objects should be reusable #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2482 +/- ##
============================================
- Coverage 50.78% 50.78% -0.01%
+ Complexity 3888 3887 -1
============================================
Files 145 145
Lines 33481 33479 -2
Branches 5690 5689 -1
============================================
- Hits 17004 17002 -2
Misses 14030 14030
Partials 2447 2447 ☔ View full report in Codecov by Sentry. |
Jeffery-Wasty
previously approved these changes
Jul 25, 2024
|
This error isn't explicitly thrown, so I can't really test by not looking for it. In the old code, this error was consumed and the driver would keep running. |
Jeffery-Wasty
approved these changes
Aug 20, 2024
lilgreenbird
approved these changes
Aug 21, 2024
tkyc
added a commit
that referenced
this pull request
Aug 21, 2024
tkyc
added a commit
that referenced
this pull request
Aug 22, 2024
tkyc
added a commit
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered that when attempting to reuse the same pstmt object, the driver would error out with
R_multipleQueriesNotAllowedand consume that error.