Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Added a missing unlock in getDestinationMetadata() (#2484) #2492

Merged
merged 1 commit into from
Aug 22, 2024
Merged

[Backport] Added a missing unlock in getDestinationMetadata() (#2484) #2492

merged 1 commit into from
Aug 22, 2024

Conversation

tkyc
Copy link
Member

@tkyc tkyc commented Aug 21, 2024 •
edited by Jeffery-Wasty
Loading

Backport of #2484.

@Jeffery-Wasty @tkyc
Added a missing unlock in getDestinationMetadata() (#2484)
92dc2da 
* Added a missing unlock

* Clean up locks as per pr review

* Added test

* Resolve codeql error

* Extend timeout time

* Removing test to narrow down on pipeline failures

* Adding a clear to see if this fixes prior errors

* PR review changes

* Address PR comments

* More
@Jeffery-Wasty Jeffery-Wasty changed the title Added a missing unlock in getDestinationMetadata() (#2484) [Backport] Added a missing unlock in getDestinationMetadata() (#2484) Aug 21, 2024
@Jeffery-Wasty Jeffery-Wasty added this to the 12.8.1 milestone Aug 21, 2024
@tkyc tkyc merged commit 64d530e into release/12.8 Aug 22, 2024
4 checks passed
@tkyc tkyc deleted the 12.8.1-deadlock-fix branch August 22, 2024 16:39
@wayneguow wayneguow mentioned this pull request Aug 23, 2024
Closed
yaooqinn pushed a commit to apache/spark that referenced this pull request Aug 26, 2024
@wayneguow @yaooqinn
[SPARK-49314][BUILD][TESTS] Upgrade h2 to 2.3.232, postgresql to …
d7f0c8f 
…42.7.4 and `mssql` to 12.8.1.jre11

### What changes were proposed in this pull request?

This PR aims to upgrade `h2` to 2.3.232, `postgresql` to 42.7.4 and `mssql` to 12.8.1.jre11.

### Why are the changes needed?

1. For `h2`, there are some issues fixed in version 2.3.232(full release notes: https://www.h2database.com/html/changelog.html):

    - [Issue #3945](h2database/h2database#3945): Column not found in correlated subquery, when referencing outer column from LEFT JOIN .. ON clause
    - [Issue #4097](h2database/h2database#4097): StackOverflowException when using multiple SELECT statements in one query (2.3.230)
    - [Issue #3982](h2database/h2database#3982): Potential issue when using ROUND
    - [Issue #3894](h2database/h2database#3894): Race condition causing stale data in query last result cache
    - [Issue #4075](h2database/h2database#4075): infinite loop in compact
    - [Issue #4091](h2database/h2database#4091): Wrong case with linked table to postgresql
    - [Issue #4088](h2database/h2database#4088): BadGrammarException when the same alias is used within two different CTEs

2. For `postgresql`, there are some issues fixed and improvements in version 42.7.4(full release notes: https://jdbc.postgresql.org/changelogs/2024-08-22-42.7.4-release/):

    - fix: PgInterval ignores case for represented interval string [PR #3344](pgjdbc/pgjdbc#3344)
    - perf: Avoid extra copies when receiving int4 and int2 in PGStream [PR #3295](pgjdbc/pgjdbc#3295)
    - fix: Add support for Infinity::numeric values in ResultSet.getObject [PR #3304](pgjdbc/pgjdbc#3304)
    - fix: Ensure order of results for getDouble [PR #3301](pgjdbc/pgjdbc#3301)
    - perf: Replace BufferedOutputStream with unsynchronized PgBufferedOutputStream, allow configuring different Java and SO_SNDBUF buffer sizes [PR #3248](pgjdbc/pgjdbc#3248)
    - fix: Fix SSL tests [PR #3260](pgjdbc/pgjdbc#3260)
    - fix: Support bytea in preferQueryMode=simple [PR #3243](pgjdbc/pgjdbc#3243)
    - fix: Fix [Issue #3234](pgjdbc/pgjdbc#3234) - Return -1 as update count for stored procedure calls [PR #3235](pgjdbc/pgjdbc#3235)
    - fix: Fix [Issue #3224](pgjdbc/pgjdbc#3224) - conversion for TIME ‘24:00’ to LocalTime breaks in binary-mode [PR #3225](pgjdbc/pgjdbc#3225)

3. For `mssql`,  there are some issues fixed in 12.8.1.jre11(full release notes: https://github.com/microsoft/mssql-jdbc/releases/tag/v12.8.1):

    - Adjusted DESTINATION_COL_METADATA_LOCK, in SQLServerBulkCopy, so that is properly released in all cases [PR #2492](microsoft/mssql-jdbc#2492)
    - Reverted "Execute Stored Procedures Directly" feature, as well as subsequent changes related to the feature [PR #2493](microsoft/mssql-jdbc#2493)
    - Changed driver behavior to allow prepared statement objects to be reused, preventing a "multiple queries are not allowed" error [PR #2494](microsoft/mssql-jdbc#2494)

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass GA.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #47810 from wayneguow/ug_h2.

Authored-by: Wei Guo <guow93@gmail.com>
Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilgreenbird lilgreenbird lilgreenbird approved these changes

@Jeffery-Wasty Jeffery-Wasty Jeffery-Wasty approved these changes

@barryw-mssql barryw-mssql barryw-mssql approved these changes

Assignees
No one assigned
Labels
None yet
Projects
MSSQL JDBC
Status: Closed/Merged PRs
Milestone
12.8.1
Development

Successfully merging this pull request may close these issues.
4 participants
@tkyc @lilgreenbird @Jeffery-Wasty @barryw-mssql