Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom quotedIdentifier and concatNullYields connection property #2540

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

lilgreenbird
Copy link
Contributor

for review only, not to be merged

@David-Engel
Copy link
Collaborator

One goal is to see how our tests behave with the options set to their non-default values. I assume everything will pass. The only small risk area in my mind is the metadata queries so ensuring those run with the non-default values is more important to me. You can simply change the default values or the properties in the PR to make testing easier.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 20 lines in your changes missing coverage. Please review.

Project coverage is 51.00%. Comparing base (b27b0c1) to head (29a12c9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 68.75% 8 Missing and 2 partials ⚠️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 68.18% 5 Missing and 2 partials ⚠️
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 72.72% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2540      +/-   ##
============================================
- Coverage     51.01%   51.00%   -0.01%     
+ Complexity     3912     3906       -6     
============================================
  Files           147      147              
  Lines         33371    33425      +54     
  Branches       5593     5603      +10     
============================================
+ Hits          17024    17050      +26     
+ Misses        13962    13961       -1     
- Partials       2385     2414      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tkyc
Copy link
Member

tkyc commented Nov 15, 2024

When a reconnect thread (for ICR) executes a TDSCommand, it needs to create a TDSCommand counter otherwise it will error out. We should add a fix for counter initialization for TDSCommands in the reconnect thread in the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

4 participants