-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom quotedIdentifier and concatNullYields connection property #2540
base: main
Are you sure you want to change the base?
Conversation
One goal is to see how our tests behave with the options set to their non-default values. I assume everything will pass. The only small risk area in my mind is the metadata queries so ensuring those run with the non-default values is more important to me. You can simply change the default values or the properties in the PR to make testing easier. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2540 +/- ##
============================================
- Coverage 51.01% 51.00% -0.01%
+ Complexity 3912 3906 -6
============================================
Files 147 147
Lines 33371 33425 +54
Branches 5593 5603 +10
============================================
+ Hits 17024 17050 +26
+ Misses 13962 13961 -1
- Partials 2385 2414 +29 ☔ View full report in Codecov by Sentry. |
When a reconnect thread (for ICR) executes a TDSCommand, it needs to create a TDSCommand counter otherwise it will error out. We should add a fix for counter initialization for TDSCommands in the reconnect thread in the main branch. |
for review only, not to be merged