Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Removing deprecated APIs in java 9" #499

Merged
merged 1 commit into from
Sep 22, 2017

Conversation

AfsanehR-zz
Copy link
Contributor

Reverts this to open the pr in the JDBC 4.3 branch

@AfsanehR-zz AfsanehR-zz merged commit 24dfd49 into dev Sep 22, 2017
@codecov-io
Copy link

codecov-io commented Sep 22, 2017

Codecov Report

Merging #499 into dev will increase coverage by 0.15%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #499      +/-   ##
============================================
+ Coverage     46.61%   46.77%   +0.15%     
- Complexity     2219     2226       +7     
============================================
  Files           108      108              
  Lines         25281    25279       -2     
  Branches       4167     4167              
============================================
+ Hits          11785    11824      +39     
+ Misses        11470    11433      -37     
+ Partials       2026     2022       -4
Flag Coverage Δ Complexity Δ
#JDBC41 46.53% <50%> (+0.13%) 2211 <0> (ø) ⬇️
#JDBC42 46.66% <50%> (+0.2%) 2224 <0> (+14) ⬆️
Impacted Files Coverage Δ Complexity Δ
.../com/microsoft/sqlserver/jdbc/SQLServerSQLXML.java 12.9% <0%> (+0.1%) 9 <0> (ø) ⬇️
.../java/com/microsoft/sqlserver/jdbc/SqlVariant.java 88.33% <0%> (ø) 13 <0> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.24% <0%> (ø) 0 <0> (ø) ⬇️
...ava/com/microsoft/sqlserver/jdbc/FailOverInfo.java 52.63% <0%> (ø) 0 <0> (ø) ⬇️
...lserver/jdbc/SQLServerDataSourceObjectFactory.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 77.22% <100%> (ø) 25 <0> (ø) ⬇️
...oft/sqlserver/jdbc/SQLServerBulkCSVFileRecord.java 41.63% <100%> (ø) 28 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 45.98% <100%> (ø) 66 <0> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.36% <50%> (-0.46%) 104 <0> (-1)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 46.01% <71.42%> (ø) 277 <0> (ø) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a1cfe...0047c3b. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Sep 22, 2017

Codecov Report

Merging #499 into dev will increase coverage by 0.15%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #499      +/-   ##
============================================
+ Coverage     46.61%   46.77%   +0.15%     
- Complexity     2219     2226       +7     
============================================
  Files           108      108              
  Lines         25281    25279       -2     
  Branches       4167     4167              
============================================
+ Hits          11785    11824      +39     
+ Misses        11470    11433      -37     
+ Partials       2026     2022       -4
Flag Coverage Δ Complexity Δ
#JDBC41 46.53% <50%> (+0.13%) 2211 <0> (ø) ⬇️
#JDBC42 46.66% <50%> (+0.2%) 2224 <0> (+14) ⬆️
Impacted Files Coverage Δ Complexity Δ
...lserver/jdbc/SQLServerDataSourceObjectFactory.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../com/microsoft/sqlserver/jdbc/SQLServerSQLXML.java 12.9% <0%> (+0.1%) 9 <0> (ø) ⬇️
.../java/com/microsoft/sqlserver/jdbc/SqlVariant.java 88.33% <0%> (ø) 13 <0> (ø) ⬇️
...ava/com/microsoft/sqlserver/jdbc/FailOverInfo.java 52.63% <0%> (ø) 0 <0> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.24% <0%> (ø) 0 <0> (ø) ⬇️
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 77.22% <100%> (ø) 25 <0> (ø) ⬇️
...oft/sqlserver/jdbc/SQLServerBulkCSVFileRecord.java 41.63% <100%> (ø) 28 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 45.98% <100%> (ø) 66 <0> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.36% <50%> (-0.46%) 104 <0> (-1)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 46.01% <71.42%> (ø) 277 <0> (ø) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a1cfe...0047c3b. Read the comment docs.

@cheenamalhotra cheenamalhotra deleted the revert-487-removal_of_deprecated_APIs branch September 23, 2017 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants