-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests | Junit improvements + Organize constants #982
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyColumnMappingTest.java # src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyConnectionTest.java # src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyISQLServerBulkRecordTest.java # src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyTimeoutTest.java # src/test/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithBulkCopyTest.java # src/test/java/com/microsoft/sqlserver/jdbc/unit/lobs/LobsStreamingTest.java # src/test/java/com/microsoft/sqlserver/jdbc/unit/lobs/LobsTest.java # src/test/java/com/microsoft/sqlserver/testframework/AbstractTest.java # src/test/java/com/microsoft/sqlserver/testframework/DBConnection.java
# Conflicts: # src/test/java/com/microsoft/sqlserver/jdbc/connection/ConnectionDriverTest.java
rene-ye
reviewed
Mar 11, 2019
src/test/java/com/microsoft/sqlserver/testframework/Constants.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #982 +/- ##
============================================
- Coverage 50.14% 50.08% -0.06%
+ Complexity 2877 2872 -5
============================================
Files 120 120
Lines 27981 27981
Branches 4677 4677
============================================
- Hits 14030 14015 -15
- Misses 11690 11712 +22
+ Partials 2261 2254 -7
Continue to review full report at Codecov.
|
ulvii
previously approved these changes
Mar 13, 2019
peterbae
previously approved these changes
Mar 13, 2019
lilgreenbird
previously approved these changes
Mar 13, 2019
# Conflicts: # src/test/java/com/microsoft/sqlserver/jdbc/JDBC43Test.java # src/test/java/com/microsoft/sqlserver/jdbc/TestUtils.java # src/test/java/com/microsoft/sqlserver/jdbc/connection/ConnectionDriverTest.java
cheenamalhotra
dismissed stale reviews from lilgreenbird, peterbae, and ulvii
via
March 13, 2019 22:16
6cb5baa
rene-ye
approved these changes
Mar 14, 2019
lilgreenbird
approved these changes
Mar 18, 2019
peterbae
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes as under:
getConnection()
method in AbstractTest class that returns Connection using available connectionString and updated tests to use this instead of creating connection fromDriverManager
.e.toString()
toe.getMessage()