Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven | Exclude non-exported packages from Javadocs #988

Merged
merged 1 commit into from
Mar 13, 2019

Conversation

cheenamalhotra
Copy link
Member

This PR changes the way we generate Javadocs for the driver.

It now excludes generating Javadocs for mssql.googlecode packages as they are not exported with driver Jars. Javadocs for future versions will look as under:

image

Copy link
Collaborator

@David-Engel David-Engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cheenamalhotra cheenamalhotra added this to the 7.3.0 milestone Mar 13, 2019
@codecov-io
Copy link

codecov-io commented Mar 13, 2019

Codecov Report

Merging #988 into dev will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #988      +/-   ##
============================================
- Coverage     50.66%   50.57%   -0.09%     
+ Complexity     2923     2920       -3     
============================================
  Files           120      120              
  Lines         27993    27993              
  Branches       4679     4679              
============================================
- Hits          14182    14157      -25     
- Misses        11520    11543      +23     
- Partials       2291     2293       +2
Flag Coverage Δ Complexity Δ
#JDBC42 50.1% <ø> (-0.06%) 2881 <ø> (+1)
#JDBC43 50.45% <ø> (-0.11%) 2913 <ø> (-3)
Impacted Files Coverage Δ Complexity Δ
...ooglecode/concurrentlinkedhashmap/LinkedDeque.java 27.69% <ø> (ø) 19 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 43.95% <0%> (-3.3%) 15% <0%> (ø)
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 58.57% <0%> (-2.37%) 33% <0%> (-2%)
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 52.23% <0%> (-1.5%) 11% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 46.86% <0%> (-1.08%) 111% <0%> (-1%)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 66.53% <0%> (-0.81%) 64% <0%> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 62.06% <0%> (-0.44%) 90% <0%> (-1%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 53.21% <0%> (-0.2%) 216% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.51% <0%> (-0.17%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 51.69% <0%> (+0.12%) 254% <0%> (+1%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f189871...930463d. Read the comment docs.

@cheenamalhotra cheenamalhotra merged commit 4e4d6bc into microsoft:dev Mar 13, 2019
@cheenamalhotra cheenamalhotra deleted the skip-javadocs branch March 14, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants