Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseLib override update #265

Merged
merged 2 commits into from
Apr 3, 2024
Merged

BaseLib override update #265

merged 2 commits into from
Apr 3, 2024

Conversation

kuqin12
Copy link
Contributor

@kuqin12 kuqin12 commented Apr 3, 2024

Preface

Please ensure you have read the contribution docs prior
to submitting the pull request. In particular,
pull request guidelines.

Description

The BaseLib is updated with new support of CRC16-CCITT-FALSE implementation. This change added the change and updated the override hash.

For each item, place an "x" in between [ and ] if true. Example: [x].
(you can also check items in the GitHub UI)

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

This change is tested on QEMU Q35 and booted to UEFI shell.

Integration Instructions

N/A

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.47%. Comparing base (222506e) to head (4064d2c).

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #265      +/-   ##
========================================
- Coverage   0.47%   0.47%   -0.01%     
========================================
  Files        144     144              
  Lines      22287   22335      +48     
  Branches      60      60              
========================================
  Hits         105     105              
- Misses     22177   22225      +48     
  Partials       5       5              
Flag Coverage Δ
MmSupervisorPkg 0.47% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuqin12 kuqin12 requested a review from apop5 April 3, 2024 19:13
@kuqin12 kuqin12 merged commit 606fc27 into microsoft:main Apr 3, 2024
9 checks passed
@kuqin12 kuqin12 deleted the baslib_update branch April 3, 2024 19:29
kenlautner pushed a commit to kenlautner/mu_feature_mm_supv that referenced this pull request Apr 11, 2024
# Preface

Please ensure you have read the [contribution
docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior
to submitting the pull request. In particular,
[pull request
guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices).

## Description

The BaseLib is updated with new support of CRC16-CCITT-FALSE
implementation. This change added the change and updated the override
hash.

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [x] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [x] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

This change is tested on QEMU Q35 and booted to UEFI shell.

## Integration Instructions

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:breaking-change Requires integration attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants