Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra parameters to Resolve-DependenciesFromAzureFeed #2655

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Arthurvdv
Copy link

Using the Resolve-DependenciesFromAzureFeed in our Azure DevOps pipelines I would like to expand this function with two extra parameters:

  • ignoreAppVersion
  • ignoredPublishers

ignoreAppVersion
Would like to retrieve the most up-to-date version from Azure Feed and ignore the specific version from the app.json

ignoredPublishers
Some Apps aren't in our Azure Feed. Based on the Publisher would like to exclude these from trying to download.

@ghost
Copy link

ghost commented Aug 29, 2022

CLA assistant check
All CLA requirements met.

@jonaswre
Copy link
Contributor

@Arthurvdv looks good. I never thought about ignoring publisher but thats a very good idea.

@jonaswre
Copy link
Contributor

jonaswre commented Aug 29, 2022

In my latest PR I used a diffrent technique for filtering dependencies.
That might be a better solution here as well.
I pass a filter thats then used by Where-Object. That allows you to filter on any attribute thats in json.

https://github.com/jonaswre/navcontainerhelper/blob/e920c13e3cb5ec3a9b4ae161a1d72b5746a273b1/AppHandling/Get-DependencyGraph.ps1#L240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants