Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Commit

Permalink
fix some bugs in v1.4 bug bash (#2066)
Browse files Browse the repository at this point in the history
  • Loading branch information
lvybriage authored Feb 17, 2020
1 parent b7045b1 commit de1ae17
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/webui/src/components/NavCon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ class NavCon extends React.Component<NavProps, NavState> {
/>
<CommandBarButton
iconProps={infoIconAbout}
text="about"
text="About"
menuProps={aboutProps}
/>
</Stack>
Expand Down
4 changes: 2 additions & 2 deletions src/webui/src/components/TrialsDetail.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class TrialsDetail extends React.Component<TrialsDetailProps, TrialDetailState>
return;
}
switch (this.state.searchType) {
case 'id':
case 'Id':
filter = (trial): boolean => trial.info.id.toUpperCase().includes(targetValue.toUpperCase());
break;
case 'Trial No.':
Expand All @@ -65,7 +65,7 @@ class TrialsDetail extends React.Component<TrialsDetailProps, TrialDetailState>
case 'Status':
filter = (trial): boolean => trial.info.status.toUpperCase().includes(targetValue.toUpperCase());
break;
case 'parameters':
case 'Parameters':
// TODO: support filters like `x: 2` (instead of `"x": 2`)
filter = (trial): boolean => JSON.stringify(trial.info.hyperParameters, null, 4).includes(targetValue);
break;
Expand Down
6 changes: 3 additions & 3 deletions src/webui/src/components/trial-detail/TableList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ class TableList extends React.Component<TableListProps, TableListState> {
name: 'Default metric',
className: 'leftTitle',
key: 'accuracy',
fieldName: 'accuracy',
fieldName: 'latestAccuracy',
minWidth: 200,
maxWidth: 300,
isResizable: true,
Expand Down Expand Up @@ -534,8 +534,8 @@ class TableList extends React.Component<TableListProps, TableListState> {
}

UNSAFE_componentWillReceiveProps(nextProps: TableListProps): void {
const { columnList } = nextProps;
this.setState({ tableColumns: this.initTableColumnList(columnList) });
const { columnList, tableSource } = nextProps;
this.setState({ tableSourceForSort: tableSource, tableColumns: this.initTableColumnList(columnList) });

}
render(): React.ReactNode {
Expand Down

0 comments on commit de1ae17

Please sign in to comment.