Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Add example of tuning RocksDB on NNI #1610

Merged
merged 6 commits into from
Oct 23, 2019
Merged

Add example of tuning RocksDB on NNI #1610

merged 6 commits into from
Oct 23, 2019

Conversation

gxiaotian
Copy link

@gxiaotian gxiaotian commented Oct 15, 2019

This PR adds example of tuning RocksDB on NNI as well as its English and Chinese documents.

@msftclas
Copy link

msftclas commented Oct 15, 2019

CLA assistant check
All CLA requirements met.

@QuanluZhang
Copy link
Contributor

looks great! the first example for tuning system parameters

@xuehui1991
Copy link
Contributor

xuehui1991 commented Oct 17, 2019

Hello @gxiaotian seems there is some syntax error which could make the PR cannot pass the IT:

./examples/trials/systems/rocksdb-fillrandom/main.py:29:24: E999 SyntaxError: invalid syntax
    args = [f"--{k}={v}" for k, v in parameters.items()]
                       ^
1     E999 SyntaxError: invalid syntax

@gxiaotian
Copy link
Author

Hi @xuehui1991 , the script runs well in my experiments. I don't know why flake8 treats it a syntax error. Do you have any clue? Thank you!

@xuehui1991
Copy link
Contributor

xuehui1991 commented Oct 21, 2019

Hi @xuehui1991 , the script runs well in my experiments. I don't know why flake8 treats it a syntax error. Do you have any clue? Thank you!

Hello @gxiaotian Could you install flake8 in your environment and reproduce this error?

@gxiaotian
Copy link
Author

gxiaotian commented Oct 21, 2019

Hi @xuehui1991 , the script runs well in my experiments. I don't know why flake8 treats it a syntax error. Do you have any clue? Thank you!

Hello @gxiaotian Could you install flake8 in your environment and reproduce this error?

Hi @xuehui1991 , great thanks for your kind help. flake8 is my major linter for python, but I can't reproduce this error. Here are the details about my flake8: 3.7.8 (mccabe: 0.6.1, pycodestyle: 2.5.0, pyflakes: 2.1.1) CPython 3.6.8 on Linux , and follows are the check results.

image

@xuehui1991 xuehui1991 requested a review from chicm-ms October 21, 2019 07:57
@xuehui1991
Copy link
Contributor

Hi @xuehui1991 , the script runs well in my experiments. I don't know why flake8 treats it a syntax error. Do you have any clue? Thank you!

Hello @gxiaotian Could you install flake8 in your environment and reproduce this error?

Hi @xuehui1991 , great thanks for your kind help. flake8 is my major linter for python, but I can't reproduce this error. Here are the details about my flake8: 3.7.8 (mccabe: 0.6.1, pycodestyle: 2.5.0, pyflakes: 2.1.1) CPython 3.6.8 on Linux , and follows are the check results.

image

Hello @chicm-ms, could you help to check the flake version of the pipeline? Thank you~

@xuehui1991 xuehui1991 merged commit bc80058 into microsoft:master Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants