This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix package installation in virtualenv and conda #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanluZhang
reviewed
Oct 22, 2019
|
|
||
| def check_output_command(file_path, head=None, tail=None): | ||
| '''call check_output command to read content from a file''' | ||
| """call check_output command to read content from a file""" |
There was a problem hiding this comment.
since you changed docstring format, I recommend you update the docstring following the discussed format :)
QuanluZhang
approved these changes
Oct 22, 2019
liuzhe-lz
reviewed
Oct 22, 2019
| python = "python" if sys.platform == "win32" else "python3" | ||
| ret = [python, "-m", "pip", "install"] | ||
| if "CONDA_DEFAULT_ENV" not in os.environ and "VIRTUAL_ENV" not in os.environ: | ||
| ret.append("--user") # not in virtualenv or conda |
There was a problem hiding this comment.
What if install as root?
liuzhe-lz
approved these changes
Oct 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1576.