This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Add comprehensive tests for tuners (merge into master) #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultmaster
changed the title
chicm-ms
reviewed
Oct 31, 2019
src/sdk/pynni/tests/test_tuner.py
Outdated
| from nni.gridsearch_tuner.gridsearch_tuner import GridSearchTuner | ||
| from nni.hyperopt_tuner.hyperopt_tuner import HyperoptTuner | ||
| from nni.metis_tuner.metis_tuner import MetisTuner | ||
| from nni.smac_tuner.smac_tuner import SMACTuner |
There was a problem hiding this comment.
There is a problem on windows: https://msrasrg.visualstudio.com/NNIOpenSource/_build/results?buildId=6298
======================================================================
ERROR: test_tuner (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: test_tuner
Traceback (most recent call last):
File "C:\agent\_work\_tool\Python\3.6.4\x64\lib\unittest\loader.py", line 428, in _find_test_path
module = self._get_module_from_name(name)
File "C:\agent\_work\_tool\Python\3.6.4\x64\lib\unittest\loader.py", line 369, in _get_module_from_name
__import__(name)
File "C:\agent\_work\5\s\src\sdk\pynni\tests\test_tuner.py", line 34, in <module>
from nni.smac_tuner.smac_tuner import SMACTuner
File "C:\agent\_work\5\s\src\sdk\pynni\nni\smac_tuner\__init__.py", line 1, in <module>
from .smac_tuner import SMACTuner
File "C:\agent\_work\5\s\src\sdk\pynni\nni\smac_tuner\smac_tuner.py", line 29, in <module>
from smac.facade.epils_facade import EPILS
ModuleNotFoundError: No module named 'smac'
----------------------------------------------------------------------
Ran 28 tests in 6.807s
FAILED
(errors=1)
Since there is problem on pipeline itself, the status of the build is sucessful, it should be failed.
|
The Windows pipeline is ready, you can resolve the conflict and submit again |
# Conflicts: # docs/en_US/Tuner/BuiltinTuner.md # src/sdk/pynni/tests/test_tuner.py
chicm-ms
approved these changes
Nov 4, 2019
QuanluZhang
approved these changes
Nov 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.