This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Support monitor mode when creating or resuming a new experiment #1933
Merged
SparkSnail
merged 31 commits into
microsoft:master
from
SparkSnail:dev-nnictl-foreground
Jan 8, 2020
Merged
Changes from 29 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
704b50e
Merge pull request #200 from microsoft/master
SparkSnail 5b0034e
Merge pull request #204 from microsoft/master
SparkSnail 8fe2588
Merge pull request #205 from microsoft/master
SparkSnail 9fae194
Merge pull request #206 from microsoft/master
SparkSnail c785655
Merge pull request #207 from microsoft/master
SparkSnail 2f5272c
Merge pull request #208 from microsoft/master
SparkSnail 1892bc2
Merge pull request #209 from microsoft/master
SparkSnail 7c1ab11
Merge pull request #210 from microsoft/master
SparkSnail 8c203f3
Merge pull request #211 from microsoft/master
SparkSnail d7a62f6
check pylint for nni_cmd
SparkSnail e259d10
fix id error
SparkSnail 4997295
Merge pull request #212 from microsoft/master
SparkSnail c037a7c
Merge pull request #213 from microsoft/master
SparkSnail 7620e7c
Merge pull request #214 from microsoft/master
SparkSnail d16dbe9
Merge pull request #215 from microsoft/master
SparkSnail 9ce751d
Merge pull request #216 from microsoft/master
SparkSnail a0846f2
Merge pull request #217 from microsoft/master
SparkSnail cd3a912
Merge pull request #218 from microsoft/master
SparkSnail 32efaa3
Merge pull request #219 from microsoft/master
SparkSnail 543239c
Merge pull request #220 from microsoft/master
SparkSnail 36e6e35
Merge pull request #221 from microsoft/master
SparkSnail f9ee589
Merge pull request #222 from microsoft/master
SparkSnail b9a7a95
Merge pull request #223 from microsoft/master
SparkSnail 1a5c017
Merge pull request #224 from microsoft/master
SparkSnail b3c6ea4
init
SparkSnail 667cf96
fix pylint
SparkSnail 392460a
Merge pull request #225 from microsoft/master
SparkSnail 69ab1d1
Merge branch 'master' of https://github.com/SparkSnail/nni into dev-n…
SparkSnail d992e2e
fix comments
SparkSnail 5756894
change command to --watch
SparkSnail 80d41db
add bash-completion for --watch command
SparkSnail File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can print dispatcher and nnimanager log here (if the status is error). Because if user is running it in a container, when the program exit, the container is destroyed too. There is no way to retrieve the error info. Another option is to disable auto_exit in case
--debug
is set.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nniManager.log content maybe too long, maybe it's not suitable to show these content in screen. Users can mount NNI's logDir in container to their local path, the logDir contains log files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the case is not for screen. For screen user, they will never seek for foreground. For container users, they don't care. Furthermore, I don't think
os.system("clear")
has any effect if they are using container. Printing a lot is expected.